Fixed bad parameter when updating configuration #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Aug 27, 2024
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Fixed bad parameter when updating configuration |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | - |
Quetzacoalt91
previously approved these changes
Aug 27, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
M0rgan01
force-pushed
the
fix-conf-update
branch
from
fd3dde0
to
b6d45da
Compare
Quetzacoalt91
previously approved these changes
Aug 28, 2024
M0rgan01
force-pushed
the
fix-conf-update
branch
from
b6d45da
to
77343a9
Compare
M0rgan01
added
Blocked
Quetzacoalt91
approved these changes
Aug 28, 2024
AureRita
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as expected.
Tested from :
1.7.8.10 to 8.1.7
8.0.5 to 8.1.7
8.1.7 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.