Fix builds #61
Merged
Fix builds #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Quetzacoalt91
commented
Jul 17, 2020
•
Quetzacoalt91
commented
| Questions | Answers |
|---|---|
| Description? | Fix builds generating archives |
| Type? | bug fix |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | / |
| How to test? | All the builds are green and the module archive can be used on a shop |
Quetzacoalt91
force-pushed
the
fix-build
branch
8 times, most recently
from
fe04ee2
to
61c6504
Compare
Quetzacoalt91
commented
Jul 17, 2020
| - name: Clean-up project | ||
| uses: PrestaShopCorp/github-action-clean-before-deploy@v1.0 | ||
| with: | ||
| paths: node_modules |
There was a problem hiding this comment.
Folder node_modules is removed before zipping the module. Can you check I may do this @NeOMakinG ?
There was a problem hiding this comment.
I think it's fine, webpack is getting every dependencies inside bundles, but we can also check if the module continue working without the folder after npm run build
NeOMakinG
reviewed
Jul 18, 2020
| @@ -13,20 +13,42 @@ jobs: | |||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2.0.0 | |||
| - name: Build JS dependencies | |||
| uses: PrestaShopCorp/github-action-build-js/12@v1.0 | |||
There was a problem hiding this comment.
Hell, this is like I did, you'r forced to do the build without our github action ? :(
There was a problem hiding this comment.
Because in a Docker context I loose the availability of the PrestaShop folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.