Remove cover query for ps1770

[pablopolyte]

Questions	Answers
Description?	Remove cover query for ps1770
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes cover image when value is "0"
How to test?	Please indicate how to best verify that this PR is correct.
Possible impacts?	Please indicate what parts of the software we need to check to make sure everything is alright.

[matks]

Hi @pablopolyte thanks for the PR! Can you give us some context? Why do you suggest to remove the cover query for PS 1770? Is there a change in PS 1.7.7 that requires this?

[kpodemski]

It's probably because we're able to get proper cover from .tpl, but I don't see changes related to this

[sarahdib]

@matks & @kpodemski it's because I found a bug on the new release of blockwishlist
#77 (comment)
This PR fix the first bug :)

[kpodemski]

@sarahdib ok, if so, this is not a solution, of course this code could be removed by:

• we need to fix checking for cover_id in core file
• in template we need to make sure that we get proper cover for combination
  here's an example: Get proper cover for product in cart and cart modal PrestaShop#21782

[Quetzacoalt91]

Hello !

We discovered that with one of the wishlist SQL requests, we could get a 0 when no image is chosen for a given combination.

The core is able to provide it by itself only if we DO NOT provide this information. As soon as we give a value, even wrong, it does nothing for us:
https://github.com/PrestaShop/PrestaShop/blob/6a880d31539ab2dcad5be32d7cdc332574a4fe43/classes/Product.php#L5494-L5499

Because of this value zero, it appears that we enter this if() block and make the core failing: https://github.com/PrestaShop/PrestaShop/blob/6a880d31539ab2dcad5be32d7cdc332574a4fe43/src/Adapter/Presenter/Product/ProductLazyArray.php#L606-L622

By leaving the core handling it completely, we get rid of this error.

[kpodemski]

@Quetzacoalt91 sure, I understand, make sure to check this PR tho:
#89

As without it y'all make sure to edit .tpl inside a module to get cover based on combination added to wishlist, not default one.

[Quetzacoalt91]

I see. Because we can't change the behavior on already released versions of PrestaShop, I guess one workaround could be found on the module side.
I'm not sure if we were supposed to find zeros in the column product_attribute_image.id_image, but we have to ask MySQL to return null when this happens.

Would the suggestion above this comment help? ⬆️

[kpodemski]

@Quetzacoalt91

you can safely remove this query :) to avoid issues with cover:

• remove this additional query from module
• on template level make sure to use $product.default_image https://github.com/PrestaShop/PrestaShop/pull/21782/files

This should be enough.

[Quetzacoalt91]

Oh okay ! I didn't get on the last message the changes were needed on the template.

Ping @pablopolyte