Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on deprecated save-state and set-output commands #27

Merged
merged 2 commits into from
May 25, 2023
Merged

Don't rely on deprecated save-state and set-output commands #27

merged 2 commits into from
May 25, 2023

Conversation

JMorinPS
Copy link
Contributor

@JMorinPS JMorinPS commented May 17, 2023 •
edited by matks
Loading

Questions Answers
Description? Apply https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company PrestaShop Corp
How to test? CI should run as expected

@JMorinPS
Copy link
Contributor Author

Original ticket
https://forge.prestashop.com/browse/INFRA-1156

@JMorinPS JMorinPS requested a review from matks May 22, 2023 08:46
@matks matks changed the title Chore: Set-Output depreciation Don't rely on deprecated save-state and set-output commands May 22, 2023
matks
matks requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JMorinPS I updated the PR title and description to make it clear what is being done here 🎐

CI is red, could you please verify?

@JMorinPS
Copy link
Contributor Author

Looks like that job named PHP Static Analysis is waiting for a specific path
Input required and not supplied: path

@JMorinPS
Copy link
Contributor Author

All good

matks
matks approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test on integration env

@matks matks added the integration-deployment To deploy the assets to the integration storage label May 22, 2023
@matks
Copy link
Contributor

matks commented May 25, 2023

Good for me 😉 thank you @JMorinPS

@matks matks removed the integration-deployment To deploy the assets to the integration storage label May 25, 2023
@matks matks merged commit 50fed68 into main May 25, 2023
@matks matks deleted the chore/set-output-depreciation branch May 25, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elodie-bil3 elodie-bil3 elodie-bil3 approved these changes

@BenjaminVouillaume BenjaminVouillaume BenjaminVouillaume approved these changes

@boherm boherm boherm approved these changes

@matks matks matks approved these changes

@djodjo3 djodjo3 Awaiting requested review from djodjo3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JMorinPS @matks @boherm @BenjaminVouillaume @elodie-bil3