-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a section for testing when they migrate a page #192
Merged
mickaelandrieu
merged 2 commits into
PrestaShop:master
from
mickaelandrieu:added-smoke-tests
Jan 29, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/content/1.7/development/architecture/migration-guide/testing.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
--- | ||
title: Testing | ||
weight: 70 | ||
--- | ||
|
||
# Testing | ||
|
||
You are encouraged to add both unit and functional tests for every new class | ||
you have created. | ||
|
||
You **must** add a smoke test (also called "survival") for every new page | ||
you migrate. | ||
|
||
## Smoke testing | ||
|
||
A smoke test is a really simple and basic test that ensure the page will load with | ||
the right HTTP code. This won't ensure the page will works as expected **but** if the test fails, this ensure the page is not functional. | ||
|
||
To add a new test, you need to add a new entry in the Data Provider of SurvivalTest class: | ||
|
||
```php | ||
<?php | ||
|
||
namespace LegacyTests\Integration\PrestaShopBundle\Controller\Admin; | ||
// ... | ||
/** | ||
* @group demo | ||
* | ||
* To execute these tests: use "./vendor/bin/phpunit -c tests-legacy/phpunit-admin.xml --filter=SurvivalTest" command. | ||
*/ | ||
class SurvivalTest extends WebTestCase | ||
{ | ||
// [...] | ||
|
||
public function getDataProvider() | ||
{ | ||
return [ | ||
'symfony_route_of_page' => ['Page title', 'symfony_route_of_page'], | ||
// ... | ||
]; | ||
} | ||
} | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be better to use
must
, wdyt?