Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent in mobile view for product listing #566

Merged

Conversation

tswfi
Copy link
Contributor

@tswfi tswfi commented Nov 28, 2023

one by line / two by line. Fixes #564

Questions Answers
Description? Mobile product listing shows consistently two products per line when paging and when loading the page.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #564
Sponsor company
How to test? Open product list, go to page X note how products are shown. Reload the page, check that the listing looks the same.

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tswfi ,

Tested with mobile, tablet and desktop.

Before :

Screen.Recording.2023-12-01.at.14.29.24.mov

After :

Screen.Recording.2023-12-01.at.14.29.47.mov

LGTM, it is QA ✅ !
Thanks!

@nicosomb nicosomb merged commit 6fe6641 into PrestaShop:develop Dec 1, 2023
6 checks passed
@tswfi tswfi deleted the consistent_columns_for_product_list branch December 2, 2023 16:05
@leemyongpakvn leemyongpakvn added this to the Beta milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mobile product list changes between one product per "line" and two products per line
6 participants