-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request to become a PrestaShop maintainer] Boubkerbribri #68
Comments
Hi @boubkerbribri and thank you for your application 😄 Following our rules, now can start discussions with current maintainers on this issue about, among other things, your motivation and skills about the project. Well, you and us know each other so maybe there won't be a lot of questions 😁 ! let's see |
No questions from my side, I already review a lot of your PRs and know what you can afford to the project and the community. That's a 👍 for me! |
No questions from my side either, we don't have anyone with your specialty in the team, so I'm sure you would bring significant value to the team! |
No questions from my side. That's a +1 for me! |
Hi @boubkerbribri I think enough time has passed, if somebody had questions, he/she was able to ask them. We should be able to perform the voting soon. Stay tuned! |
A little update about current status: AFAIK Boubker's application is about becoming a maintainer for the Browser-based Testing part of PrestaShop, which is a strong and big component that definitely can have specific maintainers. But we did not have maintainers for specific perimeters before. So we need to update the project rules (and this will require a vote) to match the new situation. Then we will be able to vote for welcoming Boubker Bribri as a Test perimeter maintainer. |
Then, let's think about other interesting areas. Maybe we can also create maintainer roles for the specifications. |
Modules |
👍 for @boubkerbribri as tests-mainteners ! |
Sorry for the very long delay. Your original request took us off guard because we had originally meant the maintainer concept as a one-size-fits-all role for developers. We never thought about how it would work for specific roles like QA automation. Since then, our understanding of the subject has evolved. We created the roles of committer and scoped maintainer, but they only address part of these issues. There's still a lot of work to be done to clarify how decisions are made and by whom. However, since you have been leading the development for UI tests for years now, I think it would make perfect sense to name you scoped maintainer for UI tests. What do you say? |
Hi @eternoendless, yes I'm ok with the role and it will fit me and SDT(s) better. |
The maintainers have voted. I have the pleasure to welcome you into the maintainers group @boubkerbribri 🎉 |
Thanks All 😄 |
About me
I’m Boubker, 29 years old and I’m a QA automation Lead at the PrestaShop company.
The beginning
Back in 2019, when I first discovered the project, I didn’t know much about Open-source (yeah, I did the mistake
open-source = free of charge
).Then I joined the team and discovered an entirely different context and concept, full of love, commitment and collaboration.
Why?
As a member of the QA team, and with the help of the team, I’m responsible for:
So why become a maintainer?
I could think of 3 reasons to become a project maintainer :
It’s the consequence of what I’m doing right now, to ‘Ensure the quality of tests’, I have to review more PRs linked to tests.
As a contributor, I’m committed to the Project’s improvement. As a maintainer, My commitment will not be just for the project, but also for contributors. It will help me discuss with them the improvements, how to add tests, adding documentation …
Becoming a Maintainer will also open up the possibility to add and maintain more tools for contributors, for example, The new modules testing library that should be open source soon.
Some numbers
You can find the details about my contributions here.
The text was updated successfully, but these errors were encountered: