Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request to become a PrestaShop maintainer] Boubkerbribri #68

Closed
boubkerbribri opened this issue Oct 6, 2021 · 13 comments
Closed

[Request to become a PrestaShop maintainer] Boubkerbribri #68

boubkerbribri opened this issue Oct 6, 2021 · 13 comments

Comments

@boubkerbribri
Copy link
Contributor

About me

I’m Boubker, 29 years old and I’m a QA automation Lead at the PrestaShop company.

The beginning

Back in 2019, when I first discovered the project, I didn’t know much about Open-source (yeah, I did the mistake open-source = free of charge).
Then I joined the team and discovered an entirely different context and concept, full of love, commitment and collaboration.

Why?

As a member of the QA team, and with the help of the team, I’m responsible for:

  • Create new UI tests and maintain old ones.
  • Ensure the quality of tests to be 100% reliable.
  • Analyse tests outcome for nightly builds.
  • Analyse tests outcome on CIs (on different projects).
  • Update tests dependencies.
  • Run all campaigns on some pull requests.

So why become a maintainer?

I could think of 3 reasons to become a project maintainer :

  1. It’s the consequence of what I’m doing right now, to ‘Ensure the quality of tests’, I have to review more PRs linked to tests.

  2. As a contributor, I’m committed to the Project’s improvement. As a maintainer, My commitment will not be just for the project, but also for contributors. It will help me discuss with them the improvements, how to add tests, adding documentation …

  3. Becoming a Maintainer will also open up the possibility to add and maintain more tools for contributors, for example, The new modules testing library that should be open source soon.

Some numbers

You can find the details about my contributions here.

image

@matks
Copy link
Contributor

matks commented Oct 6, 2021

Hi @boubkerbribri and thank you for your application 😄

Following our rules, now can start discussions with current maintainers on this issue about, among other things, your motivation and skills about the project.

Well, you and us know each other so maybe there won't be a lot of questions 😁 ! let's see

@PierreRambaud
Copy link
Contributor

No questions from my side, I already review a lot of your PRs and know what you can afford to the project and the community. That's a 👍 for me!

@kpodemski
Copy link
Contributor

No questions from my side either, we don't have anyone with your specialty in the team, so I'm sure you would bring significant value to the team!

@Progi1984
Copy link
Member

No questions from my side. That's a +1 for me!

@matks
Copy link
Contributor

matks commented Oct 18, 2021

Hi @boubkerbribri I think enough time has passed, if somebody had questions, he/she was able to ask them. We should be able to perform the voting soon. Stay tuned!

@matks
Copy link
Contributor

matks commented Oct 21, 2021

A little update about current status:

AFAIK Boubker's application is about becoming a maintainer for the Browser-based Testing part of PrestaShop, which is a strong and big component that definitely can have specific maintainers.

But we did not have maintainers for specific perimeters before. So we need to update the project rules (and this will require a vote) to match the new situation. Then we will be able to vote for welcoming Boubker Bribri as a Test perimeter maintainer.

@ttoine
Copy link
Contributor

ttoine commented Oct 21, 2021

Then, let's think about other interesting areas. Maybe we can also create maintainer roles for the specifications.
Do you see other important parts of the open source project that could benefit from having dedicated maintainers ?

@matks
Copy link
Contributor

matks commented Oct 21, 2021

Modules
Internal tools like docker images https://github.com/prestashop/docker or https://github.com/prestashop/core-weekly-generator
UI kit https://github.com/prestashop/prestashop-ui-kit

@PrestaEdit
Copy link
Contributor

👍 for @boubkerbribri as tests-mainteners !
👍 for maintener-roles !

@matks matks changed the title Request to become a PrestaShop maintainer [Request to become a PrestaShop maintainer] Request to become a PrestaShop maintainer Mar 3, 2022
@matks matks changed the title [Request to become a PrestaShop maintainer] Request to become a PrestaShop maintainer [Request to become a PrestaShop maintainer] Boubkerbribri Jun 17, 2022
@eternoendless
Copy link
Member

Hi @boubkerbribri

Sorry for the very long delay. Your original request took us off guard because we had originally meant the maintainer concept as a one-size-fits-all role for developers. We never thought about how it would work for specific roles like QA automation.

Since then, our understanding of the subject has evolved. We created the roles of committer and scoped maintainer, but they only address part of these issues. There's still a lot of work to be done to clarify how decisions are made and by whom. However, since you have been leading the development for UI tests for years now, I think it would make perfect sense to name you scoped maintainer for UI tests.

What do you say?

@boubkerbribri
Copy link
Contributor Author

Hi @eternoendless, yes I'm ok with the role and it will fit me and SDT(s) better.
Thanks.

@eternoendless
Copy link
Member

eternoendless commented Nov 7, 2022

The maintainers have voted. I have the pleasure to welcome you into the maintainers group @boubkerbribri 🎉

@boubkerbribri
Copy link
Contributor Author

Thanks All 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants