Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'releases' tag from article on patch release #686

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

sam-pires
Copy link
Contributor

@sam-pires sam-pires commented Apr 28, 2020

Same pb as last time, I removed the tag so it doesn't appear in the list of Release note.

I suggest creating a new tag 'release-note' to use for release notes, so we don't have the pb #687
Wdyt?

@sam-pires sam-pires requested review from ttoine and matks April 28, 2020 12:28
@ttoine
Copy link
Contributor

ttoine commented Apr 28, 2020

creating a new tag would mean that we must edit all the previous release note to have them in the good category. not that fun with Jekyll...

Let's remove the "release" tag in this article and keep it for the release notes. and create a new tag for this kind of article, like "process", that could include also articles about sorting issues, code review, etc. that we already published. what do you think?

@sam-pires
Copy link
Contributor Author

sam-pires commented Apr 28, 2020 via email

@ttoine
Copy link
Contributor

ttoine commented Apr 28, 2020

can you please close #687, then? or should I do it?
what do you think about the tag? what about "process"? do you have a better idea?

@sam-pires
Copy link
Contributor Author

sam-pires commented Apr 29, 2020

can you please close #687, then? or should I do it?
what do you think about the tag? what about "process"? do you have a better idea?

I updated the issue so we don't forget to create a new tag for releases-related posts that are not Release Notes.

@matks
Copy link
Contributor

matks commented Apr 29, 2020

Thank you @sam-pires

@matks matks merged commit ef96f7f into master Apr 29, 2020
@matks matks deleted the sam-pires-patch-1 branch April 29, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants