Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [Breadcrumb] add a new prop items-json #310

Closed
mattgoud opened this issue Feb 6, 2024 · 0 comments
Closed

[Feature] [Breadcrumb] add a new prop items-json #310

mattgoud opened this issue Feb 6, 2024 · 0 comments
Assignees
@mattgoud
Labels
Feature Type: New Feature

Comments

@mattgoud
Copy link
Collaborator

mattgoud commented Feb 6, 2024

What problem does this feature solve?

the web-component version of breadcrumb needs an HTML items attribute which can only accept a string value (json version of items)
@mattgoud mattgoud added the Feature Type: New Feature label Feb 6, 2024
@mattgoud mattgoud self-assigned this Feb 6, 2024
mattgoud added a commit that referenced this issue Feb 7, 2024
@mattgoud
fix: #310 - rename prop dataItems by itemsJson
cf1cdc8
mattgoud added a commit that referenced this issue Feb 9, 2024
@mattgoud
Merge pull request #311 from PrestaShopCorp/310-feature-breadcrumb-ad…
399f551 
…d-a-new-prop-items-json

fix: #310 added the dataItems prop to use in the web-component version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgoud mattgoud

Labels
Feature Type: New Feature
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

310-feature-breadcrumb-add-a-new-prop-items-json PrestaShopCorp/puik
1 participant
@mattgoud