Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Switch #7

Merged
merged 4 commits into from
Jun 1, 2022
Merged

[Component] Switch #7

merged 4 commits into from
Jun 1, 2022

Conversation

aAmorim27
Copy link
Contributor

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Added the Switch Toggle component to the library

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes

docs: added storybook documentation for switch component
packages/theme/src/switch.scss Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
feat: added a slot/prop for right label

style: adjust switch toggle size

refactor: moved switch screen reader text to a computed
@amaury-hanser
Copy link
Contributor

Good for me, I'll let you merge it.
Nice work! πŸ‘

@aAmorim27 aAmorim27 merged commit 536ca02 into main Jun 1, 2022
@aAmorim27 aAmorim27 deleted the feat/switch-component branch June 1, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants