Support CC licenses #12
Conversation
- similar to handling for rightsstatement.org Also cache property methods on the model
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## develop #12 +/- ##
===========================================
+ Coverage 99.15% 99.20% +0.04%
===========================================
Files 13 13
Lines 948 1007 +59
===========================================
+ Hits 940 999 +59
Misses 8 8 |
There was a problem hiding this comment.
The code all looks good to me. (I forgot to mention in the previous Geniza PR, but cached properties are new to me!)
I made the necessary changes to the SVGs and added notes in the readme. Not sure that's the best place, so feel free to move them elsewhere. It might also be worthwhile to include links to the following articles on CSS-Tricks:
https://css-tricks.com/svg-use-with-external-reference-take-2/
https://css-tricks.com/lodge/svg/21-get-two-colors-use/
|
@blms thanks — your updates look good to me. Readme for the SVGs seems good enough for now, can always move if we think of a better place. I'm ok without adding the links to SVG styling, that seems findable enough for anyone who wants to use it. |
No description provided.