Devel #2468
Merged
Devel #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctype structures Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
… map Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
According to the docs [0]: "Users should not touch __builtins__; it is strictly an implementation detail. Users wanting to override values in the builtins namespace should import the builtins module and modify its attributes appropriately." Since we only need the list of builtin names, use 'dir'. Fixes running in pypy3. [0] https://docs.python.org/3/reference/executionmodel.html#builtins-and-restricted-execution Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Use 'bytes' instead of 'bytearray' for RO view of ctype structures. Use np.where instead of custom selection map. User dir(builtins) instead of builtins .
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…put out of "evaluate" function The "evaluate" function input now matches that of the simulated composition. This reduces work for parallel execution of "evaluate" and enables better use of fast "shared" memory when executed on a GPU. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
This enables using the same input preprocessing codepaths as compiled composition run. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…2466) Prepares for future modification to pass multiple inputs for multiple simulation trials. Avoids duplicate construction of "predicated input" in each evaluation. Allows better use of shared memory in GPU execution.
* Update requirements.txt
…lation input (#2467) The original code assumed 'run' variant would be called. This is not the case for parallel evaluate that only needs 'run, simulation' variant, resulting in redundant code generation and compiler calls. Instead, use the 'evaluate' compiled function that provides the same binary type of the argument at a different offset. Tested by asserting that Python-{LLVM,PTX} tests only generate 'run, simulation' variant of the composition function. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
jvesely
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.