builtin and type don't exist in dash (util/make_version is invoked inconsistently)
#702
Comments
JasonGross
added a commit
to JasonGross/VST
that referenced
this issue
Aug 22, 2023
Fixes PrincetonUniversity#702 I've avoided `&>` as its not POSIX-complaint according to [stack exchange](https://unix.stackexchange.com/a/590707/45323). I've also taken the opportunity to simplify slightly the logic that checks for `git`, relying on the return code of `command -v` rather than testing that the resulting path exists.
JasonGross
added a commit
to JasonGross/VST
that referenced
this issue
Aug 22, 2023
Fixes PrincetonUniversity#702 I've avoided `&>` as its not POSIX-complaint according to [stack exchange](https://unix.stackexchange.com/a/590707/45323). I've also taken the opportunity to simplify slightly the logic that checks for `git`, relying on the return code of `command -v` rather than testing that the resulting path exists. Finally, I've removed the `2>/dev/null` redirect on `command -v`; when the command does not exist, `command -v` is already silent, and I think we want noise if `command` itself does not exist or is failing strangely for some reason.
JasonGross
added a commit
to JasonGross/VST
that referenced
this issue
Aug 22, 2023
Fixes PrincetonUniversity#702 I've avoided `&>` as its not POSIX-complaint according to [stack exchange](https://unix.stackexchange.com/a/590707/45323). I've also taken the opportunity to simplify slightly the logic that checks for `git`, relying on the return code of `command -v` rather than testing that the resulting path exists. Note that there's no `2>/dev/null` redirect on `command -v`; when the command does not exist, `command -v` is already silent, and I think we want noise if `command` itself does not exist or is failing strangely for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
util/make_versionseems to be written forbashaccording toVST/util/make_version
Line 1 in 2888663
but the
Makefileexplicitly invokes it withVST/Makefile
Line 858 in 2888663
rather than
./util/make_versionorutil/make_version(withoutsh)On systems (like default Ubuntu, I think) where
shis symlinked todash, this results inand then the script quits. This is mostly alright, though it results in the
datedefinition being the empty string. According to stack exchange,command -vis the POSIX-compliant way of writingtype -P. Alternatively, you could drop theshinvocationThe text was updated successfully, but these errors were encountered: