Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: repository 인터페이스를 domain 패키지로 이동 #73

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

scv1702
Copy link
Member

@scv1702 scv1702 commented Jul 11, 2024

✨ 구현한 기능

  • repository 인터페이스를 domain 패키지로 이동

📢 논의하고 싶은 내용

  • 상위 모듈인 application에서 하위 모듈인 infra를 의존하는 구조에서 클린 아키텍쳐에 따라 repository 인터페이스를 최상인 모듈인 domain으로 이동시킴으로써 하위 모듈이 상위 모듈을 의존하도록 변경했습니다.
  • repository 테스트의 멱등성을 위해 Testcontainers를 도입했습니다.

🎸 기타

Copy link

github-actions bot commented Jul 11, 2024

Test Results

102 tests  ±0   102 ✅ ±0   36s ⏱️ +16s
 68 suites  - 3     0 💤 ±0 
 68 files    - 3     0 ❌ ±0 

Results for commit 7bd2627. ± Comparison against base commit 31fb32f.

♻️ This comment has been updated with latest results.

@scv1702 scv1702 merged commit c2bdd5c into develop Jul 11, 2024
2 checks passed
@scv1702 scv1702 deleted the refactor/repository branch July 11, 2024 06:32
scv1702 added a commit that referenced this pull request Sep 12, 2024
* refactor: repository 인터페이스를 domain 패키지로 이동

* feat: repository 테스트의 멱등성을 위한 Testcontainers 도입
scv1702 added a commit that referenced this pull request Sep 12, 2024
* refactor: repository 인터페이스를 domain 패키지로 이동

* feat: repository 테스트의 멱등성을 위한 Testcontainers 도입
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant