Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch on travis ci on prism #1341

Closed
paladox opened this issue Mar 8, 2018 · 4 comments
Closed

Switch on travis ci on prism #1341

paladox opened this issue Mar 8, 2018 · 4 comments

Comments

@paladox
Copy link
Contributor

paladox commented Mar 8, 2018

Hi, we have the travis ci file, but i doint see any tests ran (nothing is ran on travis when creating pulls either).

https://docs.travis-ci.com/user/getting-started/

@Golmote
Copy link
Contributor

Golmote commented Mar 8, 2018

CI tests only occur when master branch is updated and when tags are pushed (i.e. a new release is made).

EDIT: Oh, that's not true actually. Some of our PRs do have a CI status. I don't know why some of them and not all, though...

@paladox
Copy link
Contributor Author

paladox commented Mar 8, 2018

Seems it only runs for the master branch. Probaly want to switch it on for gh-pages too?

@Golmote
Copy link
Contributor

Golmote commented Mar 9, 2018

Ah, you're right, the PR I was looking at was for the master branch.

So I guess we could add the gh-pages branch explicitely. Since

By default, the gh-pages branch is not built unless you add it to the safelist.

As long as we don't change the deployment rules, it should be ok.

@paladox
Copy link
Contributor Author

paladox commented Mar 11, 2018

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants