-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change case of name in composer.json #1824
Conversation
According to the docs, the package name "can contain any character, including white spaces, and it's case insensitive". Though, it is recommended to use lowercase names. Point is, our current configuration should be perfectly valid, so I don't get why it doesn't work on your side. Anyway, because the names are supposed to be case insensitive, it shouldn't be a problem to change it. /cc @mAAdhaTTah |
@RunDevelopment This isn't per Composer, but per Packagist. Listed here:
When I attempted to add the repository to Packagist, I was blocked because of the naming. |
So package names are case-insensitive and can only contain lowercase characters. Can we really change the package name without breaking the dependencies of people who are using the current name? |
@RunDevelopment I would agree. It is mystifying why it is listed as such. Ideally, Packagist would get it together. Now, I did check other Composer packages, and those all had lowercase names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If PrismJS isn't currently in Packagist, then we're not likely to break too many people by fixing the package name. The people we'd break would have to setup Prism from as a vcs respository. That group would have a pretty minor change in their composer.json
and I'm presuming have enough knowledge to fix it, if it breaks at all (Composer does say it should be case insensitive, even if Packagist doesn't agree).
I'm ok with this.
I'm looking to add Prism to a Drupal 8 project via Composer. In setting up a Packagist repository off master, I was hit with errors, since the name of the project in composer.json must be lowercase. I changed this line from:
"name": "PrismJS/prism",
to"name": "prismjs/prism",
.