Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fixed greedy lookbehinds #2030

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

RunDevelopment
Copy link
Member

This fixes a bug I found while working on #2029.

Any pattern like the following:

{
    pattern: /I don't need a lookbehind|(but) I do/,
    lookbehind: true,
    greedy: true
}

Will fail if the alternative without the lookbehind is matched.

This makes greedy lookbehinds consistent with normal lookbehinds, which already support this 'partial' lookbehind.

@RunDevelopment RunDevelopment merged commit 174ed10 into PrismJS:master Aug 29, 2019
@RunDevelopment RunDevelopment deleted the greedy-lookbehind-fix branch August 29, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant