-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured Text language support #2311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more things and we can merge this.
Co-Authored-By: Michael Schmidt <mitchi5000.ms@googlemail.com>
You are obviously good at Regex. Although mine regex works, I see how your suggestions are better. I've learned some new things today.еhank you for taking the time and explaining your changes. |
Again! What now? I cannot find errors. It was all green. After you request changes, I resolve them all but it always continues to show that I have one change request. What do I do not? I did not do anything, just changed the language name and accepted your proposals. |
🥺 Accept it already!! |
Hmm, some of the comments seem to be missed by the regex: Code:
EDIT: I guess it could be because of the whitespace before the opening bracket are tabs instead of spaces. EDIT 2: Never mind. It's the brackets. They were Chinese symbols 😂 |
We are basically there already. Just some formatting and I'll merge this. |
Somehow the |
So what else should I do? |
This. |
Btw. the |
Thank you for contributing @Serhioromano! |
No it doesn't |
New PR with clean Prism fork