Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: node.js hacks for components and prism.js #754

Merged

Conversation

valorkin
Copy link
Contributor

@valorkin valorkin commented Sep 2, 2015

@Golmote this 2 small hack allow to execute prismjs from nodejs without exceptions
I am using prismjs as loader for webpack
https://github.com/valor-software/prismjs-loader

@Golmote
Copy link
Contributor

Golmote commented Sep 2, 2015

Please do not modify prism.js directly, it is used mainly for the website. Can you update the PR to modify the files components/prism-core.js, plugins/file-highlight/prism-file-highlight.js, etc. separately?

You can then run the default gulp task to build the minified versions and the file prism.js.

@valorkin valorkin force-pushed the fix-correct-behaviour-in-nodejs branch from 0fffde4 to 9f5c93c Compare September 3, 2015 10:49
@valorkin
Copy link
Contributor Author

valorkin commented Sep 3, 2015

@Golmote updated, please review

Golmote added a commit that referenced this pull request Sep 3, 2015
Fix: node.js hacks for components and prism.js
@Golmote Golmote merged commit de7a5ca into PrismJS:gh-pages Sep 3, 2015
@Golmote
Copy link
Contributor

Golmote commented Sep 3, 2015

Thanks for contributing ;)

Golmote added a commit that referenced this pull request Sep 3, 2015
…ors in node.

Autolinker, Show invisibles and WPD can now be used with node.
Removed unused minified CSS file.
Also added missing space between attributes during wrapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants