[Bug] DialogService sets width when RelativeHeightRequest was set

[Denrage]

Description

When the RelativeHeightRequest was set through DialogLayout.RelativeHeightRequest then the DialogService overwrites the width of the popup and set it to the desired height.

https://github.com/PrismLibrary/Prism/blob/master/Source/Xamarin/Prism.Forms/Services/Dialogs/DialogService.cs#L290

Steps to Reproduce

1. Set RelativeWidthRequest and RelativeHeightRequest in XAML
2. Open Popup in App
3. The popup is now bigger than the visible area

Expected Behavior

RelativeHeightRequest would set the Popup height to a percentage of the available screen

Actual Behavior

The popup is bigger than the available screen

Basic Information

• Version with issue: v7.2.0.1367
• Last known good version: -
• Xamarin.Forms version: 4.1.0.673156
• IDE: VS 2017 15.9.13

Screenshots

Reproduction Link

DialogReproduction.zip

[nschoenberg]

I think this line is also wrong, should be using relativeHeight. Seems like copy paste Issue

Prism/Source/Xamarin/Prism.Forms/Services/Dialogs/DialogService.cs

Line 293 in b302ae7

new RelativeContentSizeConverter { RelativeSize = relativeWidth.Value },

[dansiegel]

@nschoenberg great catch!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.