Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DialogService sets width when RelativeHeightRequest was set #1894

Closed
Denrage opened this issue Sep 6, 2019 · 3 comments · Fixed by #1931
Closed

[Bug] DialogService sets width when RelativeHeightRequest was set #1894

Denrage opened this issue Sep 6, 2019 · 3 comments · Fixed by #1931
Labels

Comments

@Denrage
Copy link

Denrage commented Sep 6, 2019

Description

When the RelativeHeightRequest was set through DialogLayout.RelativeHeightRequest then the DialogService overwrites the width of the popup and set it to the desired height.

https://github.com/PrismLibrary/Prism/blob/master/Source/Xamarin/Prism.Forms/Services/Dialogs/DialogService.cs#L290

Steps to Reproduce

  1. Set RelativeWidthRequest and RelativeHeightRequest in XAML
  2. Open Popup in App
  3. The popup is now bigger than the visible area

Expected Behavior

RelativeHeightRequest would set the Popup height to a percentage of the available screen

Actual Behavior

The popup is bigger than the available screen

Basic Information

  • Version with issue: v7.2.0.1367
  • Last known good version: -
  • Xamarin.Forms version: 4.1.0.673156
  • IDE: VS 2017 15.9.13

Screenshots

image

Reproduction Link

DialogReproduction.zip

@nschoenberg
Copy link

I think this line is also wrong, should be using relativeHeight. Seems like copy paste Issue

new RelativeContentSizeConverter { RelativeSize = relativeWidth.Value },

@dansiegel
Copy link
Member

@nschoenberg great catch!

dansiegel added a commit that referenced this issue Oct 15, 2019
@dansiegel dansiegel mentioned this issue Oct 15, 2019
3 tasks
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants