Fix destory older pages when navigation from NavigationPage #1051
Conversation
…Of T that works for complex property. It takes the complex object to subscribe PropertyChanged listener as first parameter and a lambda with what property to observe as second parameter.
…Command Of T that works for complex property. It takes the complex object to subscribe PropertyChanged listener as first parameter and a lambda with what property to observe as second parameter." This reverts commit 8afcf60.
…rties of complex types.
If Detail is null, change to set the next Page to Detail in all cases.
…t does not make parts of Prism public API.
…etPropertyValue; Re-implemented PropertyObserverNode.GetPropertyValue by getting property's value by Reflection instead of Expression.Compile in order to avoid different behavior observed in Windows/Android related to iOS.
…l variable in PropertyObserverNode.GetPropertyValue
If Detail is NavigationPage, it is not necessary because it is handled correctly by ProcessNavigationForPage Method.
|
Completed. Please review. |
Onplatform updates fixes #1025
Add capability to DelegateCommand's ObservesProperty to observe properties of complex types.
…ation Update ProcessNavigationForMasterDetailPage
NetStandard Support & CI Integration
|
Can you please rebase to fix the conflicts so I can start reviewing this PR :) |
no longer swollow the exceptions made in the NavigateAsync method. We log and rethrow.
|
OK, I will respond during a few days. |
[XF] NavigationService: no longer swallow exceptions
…peToViewModelTypeResolverWhenSet After executing this UnitTest, all ViewModel becomes ViewModelLocatorFixture. For this reason, other tests result in errors.
|
I tried Rebase, but I'm not sure if this is fine. I have another consultation. I fixed UnitTest for ViewModelLocatorFixture#ShouldUseCustomDefaultViewTypeToViewModelTypeResolverWhenSet. |
|
I don't think the re-base was done properly. It seems you pulled in all the changes instead of rebasing. Could you please rebase? Maybe it will be easier for you to close this PR and open a new one? I am not sure I understand the issue with the test. Can you open a new issue so we can discuss the issue and discuss possible fixes? Thanks for your great work! |
|
OK. I make it again. |
|
I made a new PR #1051 , so I will close it. |
|
I was wrong. |
|
I made a new PR #1051 , so I will close it. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Please take a moment to fill out the following:
Fixes issue #1045.
Changes proposed in this pull request:
When there are multiple pages in Navigation Stack, when navigation from NavigationPage, Destroy of removed page from Stack is not called.
Fixed this problem.