Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularity API Alignment #1511

Merged
merged 7 commits into from
Aug 10, 2018
Merged

Modularity API Alignment #1511

merged 7 commits into from
Aug 10, 2018

Conversation

dansiegel
Copy link
Member

Description of Change

Moving what should be the final changes for the Modularity Alignment. This PR moves IModuleCatalog to the Prism.Core and further updates the API to rely on a more generic IModuleInfo than a concrete ModuleInfo type.

fixes #1290

Bugs Fixed

None.

API Changes

Reversed:

  • The ModuleInfo.ModuleType property in Prism.Forms has been changed back to System.Type hiding the underlying string IModuleInfo.ModuleType. This will make updating easier on developers who may have explicitly defined the ModuleInfo from Prism 6.X.

Added:

  • IModuleInfoGroup was added to Prism.Core to abstract the Groups, with concrete definitions required on the implementing Platform. NOTE This is not supported in Prism.Forms
  • ModuleCatalogBase. This provides a base implementation for the ModuleCatalog in the Prism.Core.
    • Prism.Wpf and Prism.Forms ModuleCatalog both expose the Items property as a content property for XAML definitions
    • Prism.Wpf maintains the CreateFromXaml in it's implementation of ModuleCatalog.

Changed:

  • IModuleCatalog -> has moved from Prism.Wpf to Prism.Core. Prism.Forms will now use the same IModuleCatalog as Prism.Wpf.
  • IModuleTypeLoader -> changed signatures to use IModuleInfo
  • ModuleManager in Prism.Forms introduces RaiseLoadModuleCompleted

Behavioral Changes

Prism.Forms ModuleManager will now resolve ModuleDependencies from the ModuleCatalog with the ModuleDependencySolver the same as Prism.Wpf

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel mentioned this pull request Jul 25, 2018
3 tasks
@brianlagunas
Copy link
Member

this looks good to merge

@brianlagunas brianlagunas merged commit 1d740d3 into master Aug 10, 2018
@dansiegel dansiegel deleted the module-final branch September 20, 2018 20:25
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Prism Modularity
2 participants