Remove DialogViewModelBase

[brianlagunas]

Description of Change

ViewModel base classes are too variant in their implementations and I have decided to remove the DialogViewModelBase class. This will force devs to create their own implementation of IDialogAware for their specific app's requirements and needs.

Bugs Fixed

• Change Request for DialogViewModelBase #1747

API Changes

Removed:

• DialogViewModelBase

[utech626]

Brian, this change makes no sense to me. I'm working on a large Geology app with over15 different dialog boxes and I have yet to have to override the DialogViewModelBase class. In my humble opinion, a library is to reduce code and not having to reinventing the wheel, so have a default implementation just makes the Dialog Services easier to implement. Thanks for your work on this, this has been a real time saver.

[brianlagunas]

@utech626 It probably doesn't make sense because you aren't talking to everyone else using it and identifying the various scenarios in which is is used. While it may work perfect for you, it doesn't for a lot more people. It's better not to include this and instead require you to add it to your own project. You are more than welcome to copy/past the code from the initial PR in which it was added.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.