Attached RegionManager to dialog by default #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noufionline
reviewed
May 25, 2019
| @@ -29,6 +32,7 @@ public void ShowDialog(string name, IDialogParameters parameters, Action<IDialog | |||
| void ShowDialogInternal(string name, IDialogParameters parameters, Action<IDialogResult> callback, bool isModal) | |||
| { | |||
| IDialogWindow dialogWindow = CreateDialogWindow(); | |||
| RegionManager.SetRegionManager((DependencyObject)dialogWindow, _regionManager); | |||
There was a problem hiding this comment.
This RegionManager will work only the first time. subsequent clicks will throw ArgumentException: Region with the given name is already registered:
Can you find a way to fix this issue?
There was a problem hiding this comment.
No, you will need to implement scoped regions to do this
There was a problem hiding this comment.
I'm actually thinking I should remove this now.
There was a problem hiding this comment.
For the same reason the base vm was removed?
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If you create and show a new Window in Prism and then try to navigate within regions, it will fail because there is no RegionManager associated with the new Window object.
The IDialogService has been modified to automatcally assign the application's RegionManager to eacvh dialog window instance so that region navigation will work out of the box
Bugs Fixed
API Changes
None
Behavioral Changes
Region navigation will now function properly when navigating within the IDialogService
PR Checklist