Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Enum for IDialogResult.Result #1826

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Conversation

brianlagunas
Copy link
Member

Description of Change

Removed the use of a bool? as the IDialogResult.Result property. Instead, added a new enum called ButtonResult

API Changes

List all API changes here (or just put None), example:

Added:

    public enum ButtonResult
    {
        Abort = 3,
        Cancel = 2,
        Ignore = 5,
        No = 7,
        None = 0,
        OK = 1,
        Retry = 4,        
        Yes = 6
    }

Changed:

  • bool? IDialogResult.Result => ButtonResult IDialogResult.Result

Behavioral Changes

The IDialogResult.Result property no longer returns a bool?, instead is now returns a ButtonResult enum value.

PR Checklist

  • Has tests (if omitted, state reason in description) - I'm lazy, so no tests yet
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas brianlagunas merged commit aee7c10 into master Jun 6, 2019
@brianlagunas brianlagunas deleted the dialog-service-updates branch June 6, 2019 18:19
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant