Allow bind Enum values in IAutoInitialize ViewModels #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue during conversion
|
replaces #1890 |
|
@candidodmv can you please rebase your PR |
Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included the conditions above.
I'm considering to use only the enum name because if the value is being considered during the conversion can cause side effect because the value as number can be refered to a lot of things in navigation parameters not the enum type searched.
@dansiegel could you check if the rabase is it right? |
dansiegel
requested changes
Nov 13, 2019
Comment on lines
+8
to
+20
| internal class MockParameters : ParametersBase | ||
| { | ||
| public MockParameters() : base() { } | ||
| public MockParameters(string query) : base(query) { } | ||
| } | ||
|
|
||
| internal enum MockEnum | ||
| { | ||
| None = 0, | ||
| Foo = 1, | ||
| Bar = 2, | ||
| Fizz = 3 | ||
| } |
There was a problem hiding this comment.
each type should be in its own file. Also mocks belong under the Mocks namespace
|
@candidodmv sorry it took a while for me to get back to you on this. If you can make this minor change then we should be good. Also need to see why the build failed. |
3 tasks
|
closing this PR as I have rebased your branch and fixed the tests. This will get merged via PR #1953 |
|
Thanks @dansiegel ! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Description of Change
Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included more conversion conditions.
Bugs Fixed
API Changes
N/A
PR Checklist