fix: GetCurrentPage for PrismWindow.Page throwing exception #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLittlesII
force-pushed
the
gh/3143
branch
2 times, most recently
from
f410682
to
251fff4
Compare
RLittlesII
changed the title
dansiegel
reviewed
May 24, 2024
dansiegel
requested changes
May 24, 2024
dansiegel
requested changes
May 24, 2024
tests/Maui/Prism.Maui.Tests/Fixtures/Common/MvvmHelperFixture.cs
Outdated
Show resolved
Hide resolved
add test cleaned up some white space
clean up test naming ensuring bug is attached to each test
clean up expected vs actual
dansiegel
reviewed
May 25, 2024
| /// This test was introduced to verify GH3143 | ||
| /// </summary> | ||
| /// <a href="https://github.com/PrismLibrary/Prism/issues/3143">Git Hub Issue 3143</a> | ||
| [Fact(Skip = "System.InvalidOperationException\nBindableObject was not instantiated on a thread with a dispatcher nor does the current application have a dispatcher.")] |
dansiegel
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed a bug that causes the sample application to crash given a
PrismWindowis somewhere on the navigation stack.Bugs Fixed
API Changes
Changed:
PrismWindowfor thePageproperty on it and passing it to theGetTargetmethodBehavioral Changes
Ensured the
PrismWindowgets properly handled and passed thePageproperty on to find the target if available.PR Checklist