-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spectator
to gameModes array
#3012
Add spectator
to gameModes array
#3012
Conversation
Lgtm, I guess. But this won't make spectator mode work in general. Mineflayers physics currently can't simulate spectator mode. |
Isn't spectator mode literally no physics? In any case, this PR was to fix that |
Thanks for the contribution |
If you want a real 'correct' implementation you would implement the flying physics. Things like drag when flying, correct speed limits and overshooting when letting go of control states. |
@IceTank implementing spectator mode physics is beyond the scope of this PR. The scope of this PR is to fix a bug. With the bug, when in spectator mode, you have no way to know that you are. |
Yes. That is correct. I just want to clarify in case anyone thinks that creative flying or spectator flying is implemented. Which it is not. |
This PR is a fix to the following bug: When in spectator mode,
bot.game.gameMode
isundefined
.The affected lines were first implemented in ad52fca.