Fix caching, relyingParty issue #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `require` does not work on relative paths, use fs.read * properly set default xbl relyingParty
kashalls
approved these changes
Aug 16, 2021
hornta
reviewed
Aug 16, 2021
| @@ -10,7 +10,7 @@ class BedrockTokenManager { | |||
| constructor (cacheLocation) { | |||
| this.cacheLocation = cacheLocation || path.join(__dirname, './bed-cache.json') | |||
| try { | |||
| this.cache = require(this.cacheLocation) | |||
There was a problem hiding this comment.
You could try to get the absolute path to the cache file using path.resolve instead of path.join, that should do it.
There was a problem hiding this comment.
Yes, but using require has other side effects like caching which is not desirable, and the cause of obscure bugs. This also brings parity with how we write to the cache.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiredoes not work on relative paths, use fs.read