add the same block events as mineflayer

[rom1504]

see https://github.com/PrismarineJS/mineflayer/blob/master/docs/api.md#blockupdate-oldblock-newblock

working towards PrismarineJS/mineflayer#334 (comment)

this will do a get at each set, making the set methods a bit slower
it is needed to keep compatibility with mineflayer

I think it is ok as initialize can be used to do a faster set for many blocks

[Karang]

prismarine-chunk is also doing a get internally for each set. Maybe we could have only 1 get per set by changing a bit the setBlock of prismarine-chunk to have it return the old block (it currently returns nothing).

https://github.com/PrismarineJS/prismarine-chunk/blob/master/src/pc/1.13/ChunkSection.js#L138

[rom1504]

yeah indeed that's an option
I see all the getBlockX are doing a getBlock before discarding most of the information. Initially these getBlockX were meant to be faster than getBlock by reading only what's needed.
Maybe we should just delete all the getBlockX and keep only getBlock and setBlock to simplify

[Karang]

yeah indeed that's an option
I see all the getBlockX are doing a getBlock before discarding most of the information. Initially these getBlockX were meant to be faster than getBlock by reading only what's needed.
Maybe we should just delete all the getBlockX and keep only getBlock and setBlock to simplify

wdym ? getBlockType and getBlockData are indeed alias for getBlockStateId, but the getBlock(Sky)Light are from different sources. imo the most important to have is getBlockStateId as getBlock is just a wrapper arround it (adding the instanciation of a Block object)

[rom1504]

ah yeah true light is from a different source
then the number of call to get block I added here cannot be decreased by moving the call to get block in pchunk because we don't do a get block call there

[Karang]

ah yeah true light is from a different source
then the number of call to get block I added here cannot be decreased by moving the call to get block in pchunk because we don't do a get block call there

What I meant is doing something like:
https://github.com/PrismarineJS/prismarine-chunk/blob/master/src/pc/1.13/ChunkColumn.js#L64

setBlock (pos, block) {
      let old = null
      if (typeof block.stateId !== 'undefined') {
        // assume each function is returning the old value
        let stateId = this.setBlockStateId(pos, block.stateId)
        old = Block.fromStateId(stateId, block.biome)
      } else {
        let stateId = this.getBlockStateId(pos)
        old = Block.fromStateId(stateId, block.biome)
      }
      if (typeof block.biome !== 'undefined') {
        old.biome = this.setBiome(pos, block.biome.id)
      } else { /*get*/ }
      if (typeof block.skyLight !== 'undefined') {
        old.skyLight = this.setSkyLight(pos, block.skyLight)
      } else { /*get*/ }
      if (typeof block.light !== 'undefined') {
        old.light = this.setBlockLight(pos, block.light)
      } else { /*get*/ }
      return old
    }

[rom1504]

yes I got it.
But in this PR, I added a getBlock in every setBlockX, where we don't do any getBlock currently, even in pchunk

[rom1504]

ah or do you mean replacing all the setBlockX by this setBlock ?

[rom1504]

I'll try to use this in mineflayer before merging