Skip to content

Conversation

greut
Copy link
Collaborator

@greut greut commented Aug 30, 2017

Taylor made yet another breaking change in a minor version...

Ref. laravel/framework#20464

What is the best way to tackle this down?

Ref. laravel/framework#20464

Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@Lorti
Copy link
Collaborator

Lorti commented Aug 31, 2017

Thanks, Yoan!
Would you step up a major version (1.5.0 to 2.0.0) or just a minor version (1.5.0 to 1.6.0) with this change? 😅

@markusjwetzel What do you prefer?

@Lorti Lorti merged commit a14a596 into ProAI:master Aug 31, 2017
@Lorti
Copy link
Collaborator

Lorti commented Aug 31, 2017

It's going to be a minor version bump.

@markusjwetzel
Copy link
Contributor

I think we did a minor version bump in a similar situation in the past, so a minor version bump is totally okay. Thanks, greut & Lorti! :)

@greut greut deleted the laravel55 branch August 31, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants