Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable determining blueprint from GitHub repo #3

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Enable determining blueprint from GitHub repo #3

merged 2 commits into from
Oct 6, 2021

Conversation

Celeo
Copy link
Contributor

@Celeo Celeo commented Oct 2, 2021

Fixes #2

I had to make more changes than I sought out to make; let me know if anything doesn't make sense and we can review.

Happy Hacktoberfest!

@ProCode2 ProCode2 self-requested a review October 2, 2021 20:21
Copy link
Owner

@ProCode2 ProCode2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made me you fan sir! 🙏 I will test it out and merge as soon as I can find some time out. Till then approving this so that it counts for Hacktoberfest ;)

Thanks a lot!

@ProCode2
Copy link
Owner

ProCode2 commented Oct 4, 2021

Hey @Celeo , the function seems to save the path of the temp dir instead of the actual name of the root folder in the json?

Reproduce:

# run
cargo run -q -- -r procode2/hpm

cargo run -q -- -g ./hpm.json

See the name of the root folder in json.
Screenshot 2021-10-05 at 12 07 02 AM

@ProCode2
Copy link
Owner

ProCode2 commented Oct 6, 2021

Nvm added a workaround. :)

@ProCode2 ProCode2 merged commit 9168f33 into ProCode2:main Oct 6, 2021
@Celeo
Copy link
Contributor Author

Celeo commented Oct 6, 2021

Great, thank you for the help!

@Celeo Celeo deleted the enable-remote-calculate branch October 6, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for generating JSON blueprint from github repository
2 participants