Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/FOUR-12702: Start a Request: we need to enable only if the user was assigned "Start Permission" #5934

Merged
merged 18 commits into from
Jan 12, 2024

Conversation

luNunezProcessmaker
Copy link
Contributor

@luNunezProcessmaker luNunezProcessmaker commented Jan 5, 2024

Issue & Reproduction Steps

  1. Create a process with start event
  2. Assign a specific user or group
  3. Go to Processes and Start a request with a different user not assigned in the Start Permission
  4. Go to Processes and Start a request with a different user not assigned in the group Start Permission
  5. The START THIS PROCESS can not enable if the user was not assigned in the “Start Permission“

When the user does not have permission or the process does not have any start request to show use this style… disable the button

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-12702
But the PR solves the following tickets

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next
ci:APP_DEBUG=true

@tokensPM
Copy link

tokensPM commented Jan 8, 2024

QA server was successfully deployed https://ci-3a4af8a104.eng.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-e25ca07418.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

pmPaulis commented Jan 11, 2024

@luNunezProcessmaker
I reviewed in the build generated:
When the start event is Group and any group is assigned the following error is giving
Screenshot from 2024-01-11 14-07-10

image

The expected is disable the button
image

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-e25ca07418.engk8s.processmaker.net

Copy link

processmaker-sonarqube bot commented Jan 12, 2024

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-e25ca07418.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

pmPaulis commented Jan 12, 2024

I reviewed the following use cases and this is working

Processes.Catalogue.-.ProcessMaker.mp4

@ryancooley ryancooley merged commit e8f43f3 into next Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants