Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/FOUR-13113: The slider lines of the carousel are not the same as figma #5954

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

CarliPinell
Copy link
Contributor

How to Test

  • Open Any Process with "Open in Launchpad" and check Carousel Sliders

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-13113

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ci:deploy
    ci:next

@tokensPM
Copy link

tokensPM commented Jan 8, 2024

QA server was successfully deployed https://ci-203ade53b2.eng.processmaker.net

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

tokensPM commented Jan 9, 2024

QA server K8S was successfully deployed https://ci-6582783252.engk8s.processmaker.net

@ryancooley ryancooley merged commit a332936 into next Jan 10, 2024
6 checks passed
@pmPaulis pmPaulis changed the title QA Observation Bugfix/FOUR-13113: The slider lines of the carousel are not the same as figma bugfix/FOUR-13113: The slider lines of the carousel are not the same as figma Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants