Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13090 Close active sessions when Block duplicate session is activated #5956

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Jan 8, 2024

Issue & Reproduction Steps

The already duplicated active sessions are still active when Block duplicate session is activated.

Solution

  • Close active sessions when Block duplicate session is activated .

How to Test

  • Log in
  • Create a new user
  • Log in with new user in diferent browser (in a same IP)
  • From admin user configure Block duplicate session in IP Restriction
  • Go to Admin tab
  • Go to settings option in sidebar menu
  • Go to Session Control tab
  • Go to IP Restriction and edit
  • Enable Block duplicate session
  • Click on save button

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@caleeli caleeli changed the base branch from develop to feature/FOUR-11378 January 8, 2024 21:49
@tokensPM
Copy link

tokensPM commented Jan 8, 2024

QA server was successfully deployed https://ci-06c26078fa.eng.processmaker.net

Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tokensPM
Copy link

tokensPM commented Jan 9, 2024

QA server K8S was successfully deployed https://ci-ff31518069.engk8s.processmaker.net

Copy link

@tokensPM
Copy link

tokensPM commented Jan 9, 2024

QA server K8S was successfully deployed https://ci-ff31518069.engk8s.processmaker.net

@caleeli caleeli merged commit c94300e into feature/FOUR-11378 Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants