Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

feat(no ticket): AtlasBanner #37

Merged
merged 9 commits into from
Mar 1, 2023
Merged

Conversation

litingchu
Copy link
Contributor

@litingchu litingchu commented Feb 27, 2023

Feature

Feature Description

Description of the feature being implemented.

  • created AtlasBanner component

Screenshot

Screen Shot 2023-02-28 at 12 10 15 PM

Ticket

Ticket

Checklist

  • Tests
  • Validated Against Design

"AtlasBanner--button": label,
});

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 excellent

Copy link
Contributor

@nullcitizen nullcitizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just 100% technically correct. There is no feedback to give except this is exactly as expected.

@nullcitizen
Copy link
Contributor

I suppose those conflicts need resolving but otherwise good to go

@litingchu litingchu merged commit 1a06131 into main Mar 1, 2023
@litingchu litingchu deleted the feat/no-ticket-atlas-banner branch March 1, 2023 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants