Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack Implementation II #99

Merged
merged 6 commits into from
Oct 4, 2014
Merged

Conversation

paddatrapper
Copy link
Contributor

Fixes all of issue #73 and #97. Monsters now have a chance of spawning and a chance to automatically attack players. There are safe areas where danger = 0 in locations.json. The gold from the monster is gained by the player when he kills it. Attack option halves armour and multiplies damage by 1.75. Defence doubles armour and halves attack.

@projectdelphai
Copy link
Member

why 1.75 for damage and double for armour? not only the inconsistency but also the fact that choosing one option or the other isn't a bonus or stat boost. It just prioritizes one over the other. So I would think that if you chose one option (say attack) your attack stat would stay the same (there's no way it can magically rise unless critical hit) but the other stat (in this case, armour) would drop (by half although that may be a lot) because you're not paying too much attention to defending.

@paddatrapper
Copy link
Contributor Author

2 proved to big for attacking because it resulted in no fight - killed
monsters in 1 or 2 turns. So I reduced it
On 03 Oct 2014 5:05 PM, "Reuben Castelino" notifications@github.com wrote:

why 1.75 for damage and double for armour? not only the inconsistency but
also the fact that choosing one option or the other isn't a bonus or stat
boost. It just prioritizes one over the other. So I would think that if you
chose one option (say attack) your attack stat would stay the same (there's
no way it can magically rise unless critical hit) but the other stat (in
this case, armour) would drop (by half although that may be a lot) because
you're not paying too much attention to defending.


Reply to this email directly or view it on GitHub
#99 (comment).

@projectdelphai
Copy link
Member

@paddatrapper that's why i'm proposing not to increase the relevant stat at all, just reduce the other one. Makes more sense to reduce than to attack since you're not actually increasing either attack or armour just making one less priority.

@paddatrapper
Copy link
Contributor Author

OK, sure. Will do

@projectdelphai projectdelphai merged commit 173953c into Progether:master Oct 4, 2014
@paddatrapper paddatrapper deleted the attack branch October 5, 2014 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants