Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Empty Vertices + Mutation Indication and Graph display in GUI #58

Closed
wants to merge 24 commits into from

Conversation

joswinter
Copy link
Contributor

Mutation indication is working, implemented the graph display into the GUI with some mock data. Alignment is still skewed because of the sorting of the edges on destination start position.
#13: Insert empty nodes (insertion / deletion) in DNA sequence graph
#15 Indicate mutation types based on empty tiles and relative

coordinates (insertion, deletion and SNP)

#13: Insert empty nodes (insertion / deletion) in DNA sequence graph

#15 Indicate mutation types based on empty tiles and relative
coordinates (insertion, deletion and SNP)
Iterator sorting is independent
Hashset equality doesn't seem to work, use array cast instead
bug found by visualizing the graph
should be based on start instead of absStart
Added Note: Beware, temporary code which will be obsolete with #56
Internal sorting of edges on destination starting position
trigger index out of bounds exception occassionaly
@jorenham
Copy link
Contributor

You should mark the obsolete methods/classes with @Deprecated

DefaultGraphParser.java:125
You create a new SegmentString, this clashes with dependency injection; you should pass a SegmentString factory to the method

TileView.sequenceColor
The color code constants should be (static) final fields. Better yet, use css for this by setting the styleclass and putting the color for the styleclasses in the css file.

Vertex.java
This class is a view, so it should be named that way.

@alangerak
Copy link
Contributor

TileView.sequenceColor
It is better practice to use either overloading methods or make a method in the interface of mutation and implement those in the relevant mutation classes.

@joswinter
Copy link
Contributor Author

We should wait with implementing the style into a stylesheet. It would be best to do this in a whole in a later pull request. I will create an issue for that.

Fixed most of the remarks for the pull request, so can be merged.

@joswinter joswinter closed this May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants