Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback sprint 5 #71

Open
lkrombeen opened this issue May 31, 2017 · 0 comments
Open

Feedback sprint 5 #71

lkrombeen opened this issue May 31, 2017 · 0 comments
Assignees

Comments

@lkrombeen
Copy link
Collaborator

sprint planning:

  • Prioritization is better. Adjust it slightly so the different categories are also prioritized e.g. which issue with priority label A is the most important, put that above the other issues with a label A.
  • Link back to user stories in your issues and add user stories to your project board..
  • You have many large tasks. Try splitting them into smaller tasks.
  • Some issue descriptions can be improved e.g. Upgrade GUI to allow zooming #53 what will be the action to zoom?
  • Last weeks estimation were okay (except Tycho) so there is no need to focus on improving that significantly.
    code evaluation
  • No commits to master, good.
  • You still are not closing the FileInputStreams and others.
  • The following statement in FileSelector is always true: chosenFile != null
  • Discussions in PRs are good, issues can be improved.
  • Add pictures to your README file.
  • Update your architecture document.
  • Good to see some tests. Still very minimal though. Are you using a tool like Cobertura? I currently get 5% branch coverage with is so maybe we have a mismatch? Because if that is the case, you deserve a higher grade ;)
@lkrombeen lkrombeen self-assigned this May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant