This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Changed genre fields from uppercase to lowercase #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmrd993
changed the title
knjk04
reviewed
May 16, 2020
| MEMOIR("Memoir"), | ||
| MYSTERY("Mystery"), | ||
| NON_FICTION("Non-fiction"), | ||
| PERIODICAL("Perdiodical"), |
There was a problem hiding this comment.
Small typo here. This should be "Periodical"
knjk04
reviewed
May 16, 2020
| COOKBOOK("Cookbook"), | ||
| COMEDY("Comedy"), | ||
| COMICS("Comics"), | ||
| CRIME("Crimes"), |
There was a problem hiding this comment.
I'm being quite pedantic here, but could you please change "Crimes" to "Crime"?
knjk04
suggested changes
May 16, 2020
|
Done |
knjk04
approved these changes
May 16, 2020
kaansonmezoz
pushed a commit
to kaansonmezoz/book-project
that referenced
this pull request
Aug 2, 2020
Change genre fields from uppercase to lowercase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if it's what you want. Here is a screenshot of the changes.