Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678.
Description
Currently
NiftiSaver
(therefore defaultSaveImage
andSaveImaged
) saves images as(H,W,D,C)
, even if input image had no channel dimension, or was only a 2D image.This PR allows users to squeeze trailing singleton dimensions. If C==1, image will be saved as
(H,W,D)
. If D is also == 1, image will be saved as(H,W)
. If D==1, but C>1, image will still be saved as(H,W,D,C)
(to avoid channel dimension being interpreted as depth).I also changed the saved path fromEDIT: I reverted this for backwards compatibility, but I still find it ugly./some/path/filename/filename.nii.gz
to/some/path/filename.nii.gz
, as I assumed the former was a mistake. I can undo this if it was intentional.Status
Ready
Types of changes
./runtests.sh --codeformat --coverage
../runtests.sh --quick
.make html
command in thedocs/
folder.