Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710.
Description
The problem was that for
class_idx=None
, theargmax
was used intraining_mode
, resulting in different inferred classes compared toeval_mode
. Secondly, the model was getting silently updated. Solved by usingself.model.eval()
but not usingwith torch.no_grad()
orwith eval_mode(self.model)
.I've added a new test to check that when
class_idx=None
the inferred model is the same as that usingeval_mode
.Status
Ready
Types of changes
./runtests.sh --codeformat --coverage
../runtests.sh --quick
.