Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2541 adds whats new 0.6 #2550

Merged
merged 6 commits into from
Jul 8, 2021
Merged

2541 adds whats new 0.6 #2550

merged 6 commits into from
Jul 8, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 7, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #2541

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review July 8, 2021 12:43
@wyli wyli requested a review from Nic-Ma July 8, 2021 12:43
@wyli
Copy link
Contributor Author

wyli commented Jul 8, 2021

Hi @Nic-Ma @yiheng-wang-nv, I'll tag 0.6 after merging this one. do you have any other pending PRs?

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a minor comment.

Thanks.

docs/source/whatsnew_0_6.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jul 8, 2021

I think @yiheng-wang-nv and I don't have other pending PRs.
Please feel free to tag v0.6.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Jul 8, 2021

/build

1 similar comment
@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

wyli added 4 commits July 8, 2021 16:18
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This reverts commit a980ae4.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Jul 8, 2021

I think @yiheng-wang-nv and I don't have other pending PRs.
Please feel free to tag v0.6.

Thanks.

Hi @Nic-Ma, I reverted a980ae4, because the integration test failed. #2531 is not a critical feature, so let's postpone it to after v0.6.0

@wyli wyli merged commit 0ad9e73 into Project-MONAI:dev Jul 8, 2021
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jul 8, 2021

Hi @wyli ,

Sure, it's not a blocking issue I think.

Thanks.

@wyli wyli deleted the 2541-whats-new branch July 8, 2021 23:23
@wyli
Copy link
Contributor Author

wyli commented Jul 8, 2021

Hi @wyli ,

Sure, it's not a blocking issue I think.

Thanks.

thanks for confirming, then I'll release 0.6 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adds a 'what's new in 0.6.0' page
3 participants