Return name and ref response fields separately #2857

karenzshea · 2016-09-05T13:42:36Z

Issue

Ref #2704
Splits name and ref into separate fields in the response object.

Tasklist

add regression / cucumber cases (see docs/testing.md)
review
adjust for for comments

Requirements / Relations

Enables #2744 and #2845

cc @daniel-j-h @MoKob @emiltin

daniel-j-h · 2016-09-05T13:49:55Z

@emiltin this will finally provide separate name, ref, destination fields in the response when it lands, no longer having to parse the weird name (ref) construct we're currently having.

Which also means your parsing code will probably have to change. Just keeping you in the loop here.

daniel-j-h · 2016-09-05T14:28:49Z

MoKob · 2016-09-06T14:14:09Z

features/bicycle/names.feature

@@ -16,7 +16,7 @@ Feature: Bike - Street names in instructions

        When I route I should get
            | from | to | route                                   |
-            | a    | c  | My Way (A6),Your Way (A7),Your Way (A7) |
+            | a    | c  | My Way,Your Way,Your Way                |


these have to be added as an additional check instead of being removed | route | ref | ... or something like this. References are an essential part of guidance checks.

emiltin · 2016-09-06T21:18:00Z

thanks @daniel-j-h for the update

daniel-j-h · 2016-09-07T10:01:47Z

CHANGELOG.md

    - Guidance
      - Handle Access tags for lanes, only considering valid lanes in lane-guidance (think car | car | bike | car)
    - API:
      - `annotations=true` now returns the data source id for each segment as `datasources`
      - Reduced semantic of merge to refer only to merges from a lane onto a motorway-like road
+      - new `ref` field in the `RouteStep` object


What is is good for? Also maybe a note about "name (ref)" -> name, ref.

daniel-j-h · 2016-09-07T10:37:40Z

features/guidance/dedicated-turn-roads.feature

-            | waypoints | route                                                     | turns                    |
-            | a,o       | Schwarzwaldstrasse (L561),Ettlinger Allee,Ettlinger Allee | depart,turn right,arrive |
+            | waypoints | route                                                    | turns                    | ref        |
+            | a,o       | Schwarzwaldstrasse,Ettlinger Allee,Ettlinger Allee       | depart,turn right,arrive | L561,L561, |


Before it was a single ref, now it's two refs?

Looks like in post-processing, whenever name gets updated, refs are not getting updated accordingly

This is actually an existing bug where in post-processing we don't properly update collapsed steps with the correct destination and pronunciation data along with name. PR coming for this fix, which can then include moving ref in preprocessing as well.

#2857

MoKob · 2016-09-07T11:26:33Z

From discussion in chat. We are trying to include this in 5.4.0. I updated the milestone accordingly

daniel-j-h · 2016-09-07T19:05:06Z

include/extractor/extractor_callbacks.hpp

@@ -39,7 +54,7 @@ class ExtractorCallbacks
    // used to deduplicate street names and street destinations: actually maps to name ids
    using MapKey = std::tuple<std::string, std::string, std::string>;
    using MapVal = unsigned;
-    std::unordered_map<MapKey, MapVal, boost::hash<MapKey>> string_map;
+    std::unordered_map<MapKey, MapVal, std::hash<MapKey>> string_map;


std::hash is the default, you can remove this. See http://en.cppreference.com/w/cpp/container/unordered_map

MoKob · 2016-09-08T11:35:21Z

features/foot/ref.feature

@@ -26,7 +26,7 @@ Feature: Foot - Way ref

        When I route I should get
            | from | to | route |
-            | a    | b  | E7,E7 |
+            | a    | b  | {highway:primary},{highway:primary} |



align table

@karenzshea

With @karenzshea's name / ref split (ref. #2857) in master we want to make use of it and reduce `NewName` instructions when ever possible. This is a first step towards #2744 by using the already existing name change heuristic from the extractor now in post-processing as well. Limitations: at the moment we don't have the `SuffixTable` in post-processing; this would require us serializing and subsequently deserializing the table, passing it through from the profiles to the API.

@karenzshea

With @karenzshea's name / ref split (ref. #2857) in master we want to make use of it and reduce `NewName` instructions when ever possible. This is a first step towards #2744 by using the already existing name change heuristic from the extractor now in post-processing as well. Limitations: at the moment we don't have the `SuffixTable` in post-processing; this would require us serializing and subsequently deserializing the table, passing it through from the profiles to the API.

@karenzshea

With @karenzshea's name / ref split (ref. #2857) in master we want to make use of it and reduce `NewName` instructions when ever possible. This is a first step towards #2744 by using the already existing name change heuristic from the extractor now in post-processing as well. Limitations: at the moment we don't have the `SuffixTable` in post-processing; this would require us serializing and subsequently deserializing the table, passing it through from the profiles to the API.

@karenzshea

With @karenzshea's name / ref split (ref. #2857) in master we want to make use of it and reduce `NewName` instructions when ever possible. This is a first step towards #2744 by using the already existing name change heuristic from the extractor now in post-processing as well. Limitations: at the moment we don't have the `SuffixTable` in post-processing; this would require us serializing and subsequently deserializing the table, passing it through from the profiles to the API.

References: - #2857 - #2900 - #2909

daniel-j-h added Work In Progress Refactor labels Sep 5, 2016

daniel-j-h added this to the 5.4.0 milestone Sep 5, 2016

daniel-j-h assigned karenzshea Sep 5, 2016

MoKob modified the milestones: 5.5.0, 5.4.0 Sep 6, 2016

MoKob reviewed Sep 6, 2016
View reviewed changes

daniel-j-h mentioned this pull request Sep 7, 2016

Split a way's "Name (Ref)" into name, ref fields #2704

Closed

daniel-j-h reviewed Sep 7, 2016
View reviewed changes

karenzshea force-pushed the refxit branch 2 times, most recently from 8fdb350 to 9823778 Compare September 7, 2016 10:21

daniel-j-h reviewed Sep 7, 2016
View reviewed changes

MoKob modified the milestones: 5.4.0, 5.5.0 Sep 7, 2016

karenzshea force-pushed the refxit branch from 7507818 to adad46e Compare September 7, 2016 14:51

1ec5 mentioned this pull request Sep 7, 2016

Serialize ref field mapbox/mapbox-directions-swift#67

Closed

karenzshea force-pushed the refxit branch from adad46e to 1ec002a Compare September 7, 2016 15:15

karenzshea added Review and removed Work In Progress labels Sep 7, 2016

daniel-j-h reviewed Sep 7, 2016
View reviewed changes

MoKob reviewed Sep 8, 2016
View reviewed changes

MoKob added Ready To Merge and removed Review labels Sep 8, 2016

return name and reference separately

dcc1b5a

MoKob force-pushed the refxit branch from 74b10d5 to dcc1b5a Compare September 8, 2016 12:28

MoKob merged commit dcc1b5a into master Sep 8, 2016

MoKob deleted the refxit branch September 8, 2016 12:53

daniel-j-h mentioned this pull request Sep 12, 2016

Reduce NewName Instructructions / Name Changes #2900

Merged

7 tasks

daniel-j-h added a commit that referenced this pull request Sep 22, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

488daf6

References: - #2857 - #2900 - #2909

daniel-j-h mentioned this pull request Sep 22, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids #2945

Merged

4 tasks

daniel-j-h added a commit that referenced this pull request Sep 28, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

50b20df

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Sep 29, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

3c801df

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Sep 29, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

bf5b51a

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 5, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

0a62495

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 10, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

f1d2aae

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 12, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

89a2719

References: - #2857 - #2900 - #2909

MoKob pushed a commit that referenced this pull request Oct 13, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

04956d3

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 13, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

103ffbd

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 14, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

c386f69

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Oct 25, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

eec633d

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Nov 7, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

87138ff

References: - #2857 - #2900 - #2909

MoKob pushed a commit that referenced this pull request Nov 8, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

afc9b8b

References: - #2857 - #2900 - #2909

daniel-j-h added a commit that referenced this pull request Nov 8, 2016

Uses Name Change Heuristic Instead of Comparing Name Ids

c1651cc

References: - #2857 - #2900 - #2909

daniel-j-h mentioned this pull request Jun 27, 2017

Include Exit Numbers and expose them in RouteStep #3400

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return name and ref response fields separately #2857

Return name and ref response fields separately #2857

karenzshea commented Sep 5, 2016 •

edited by MoKob

Loading

daniel-j-h commented Sep 5, 2016

daniel-j-h commented Sep 5, 2016 •

edited by karenzshea

Loading

MoKob Sep 6, 2016

emiltin commented Sep 6, 2016

daniel-j-h Sep 7, 2016

daniel-j-h Sep 7, 2016

MoKob Sep 7, 2016

karenzshea Sep 7, 2016 •

edited

Loading

MoKob commented Sep 7, 2016

daniel-j-h Sep 7, 2016

MoKob Sep 8, 2016

Return name and ref response fields separately #2857

Return name and ref response fields separately #2857

Conversation

karenzshea commented Sep 5, 2016 • edited by MoKob Loading

Issue

Tasklist

Requirements / Relations

daniel-j-h commented Sep 5, 2016

daniel-j-h commented Sep 5, 2016 • edited by karenzshea Loading

MoKob Sep 6, 2016

Choose a reason for hiding this comment

emiltin commented Sep 6, 2016

daniel-j-h Sep 7, 2016

Choose a reason for hiding this comment

daniel-j-h Sep 7, 2016

Choose a reason for hiding this comment

MoKob Sep 7, 2016

Choose a reason for hiding this comment

karenzshea Sep 7, 2016 • edited Loading

Choose a reason for hiding this comment

MoKob commented Sep 7, 2016

daniel-j-h Sep 7, 2016

Choose a reason for hiding this comment

MoKob Sep 8, 2016

Choose a reason for hiding this comment

karenzshea commented Sep 5, 2016 •

edited by MoKob

Loading

daniel-j-h commented Sep 5, 2016 •

edited by karenzshea

Loading

karenzshea Sep 7, 2016 •

edited

Loading