Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist steps from the car profile #3668

Merged
merged 3 commits into from Feb 8, 2017
Merged

Blacklist steps from the car profile #3668

merged 3 commits into from Feb 8, 2017

Conversation

TheMarex
Copy link
Member

@TheMarex TheMarex commented Feb 7, 2017 •
edited

Issue

Fixes #3435

Tasklist

  • review
  • adjust for comments

@TheMarex TheMarex added this to the 5.6.0 milestone Feb 7, 2017
emiltin
emiltin reviewed Feb 7, 2017
View reviewed changes
features/car/access.feature
@@ -256,3 +256,11 @@ Feature: Car - Restricted access
| highway | motor_vehicle | motor_vehicle:forward | motor_vehicle:backward | forw | backw |
| footway | | | destination | | x |
| track | destination;agricultural | destination | | x | x |

Scenario: Car - Don't route over steps even if marked as accessible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, be a little adventurous :-p

daniel-j-h
daniel-j-h reviewed Feb 7, 2017
View reviewed changes
Copy link
Member

@daniel-j-h daniel-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you port failing test in this pull request

#3436

which we used to point out current behavior and / or close the pull request then.

features/car/access.feature
| highway | access | forw | backw |
| steps | yes | | |
| steps | no | | |
| primary | | x | x |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be so kind to add Cucumber tests for walk and bike, too.

@TheMarex TheMarex mentioned this pull request Feb 7, 2017
Closed
@TheMarex TheMarex merged commit aa3f208 into master Feb 8, 2017
@TheMarex TheMarex deleted the profile/no-steps branch February 8, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiltin emiltin emiltin left review comments

@daniel-j-h daniel-j-h daniel-j-h approved these changes

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheMarex @emiltin @daniel-j-h @MoKob