pass flags into process_segment

[mattwigway]

Issue

This partially addresses #6145, by making the extractor edge flags available to process_segment as segment.flags. This allows accessing road classification, start point, etc. in process_segment. I'm using it by tagging bridges/tunnels as non-startpoints and then not applying elevation weighting to them since they are flat (ish) where I am but often cross deep valleys.

I'm not quite sure how to write an automated test for this. Maybe a profile that uses the flags information in a cucumber test?

Tasklist

• CHANGELOG.md entry (How to write a changelog entry)
• update relevant Wiki pages
• add tests (see testing documentation)
• review
• adjust for comments
• cherry pick to release branch

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

[mjjbell]

I'm not quite sure how to write an automated test for this. Maybe a profile that uses the flags information in a cucumber test?

Yes, take a look at https://github.com/Project-OSRM/osrm-backend/blob/master/features/options/extract/lua.feature and https://github.com/Project-OSRM/osrm-backend/blob/master/features/options/extract/turn_function.feature.

You could write a test that uses the flags within the profile's process_segment function and confirm you get the expected result.

[mattwigway]

I'm having some trouble getting the Cucumber tests running to finish this, which seems to have to do the node OSRM library. It looks like it's trying to find it locally, failing, and then trying to grab it from github, which fails as well since it's a non-release version. Do I need to do something to build the Node.js bindings locally?

[mattwigway]

Okay, I figured out the Cucumber tests and added a test that confirms that segment flags get passed through to process_segment. @mjjbell let me know if anything else is needed and my apologies for the delay.

[mjjbell]

LGTM. Please add a changelog entry.

[mattwigway]

@mjjbell I added the changelog entry and rebased to avoid merge conflicts in changelog. Thanks!