Fix improvement calculation #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhadka
commented
Jan 24, 2024
platypus/core.py
Outdated
| @@ -987,9 +987,11 @@ def add(self, solution): | |||
| else: | |||
| self._contents = list(itertools.compress(self._contents, nondominated)) + [solution] | |||
|
|
|||
| if dominated and not_same_box: | |||
| if any(dominated) and all(not_same_box): | |||
There was a problem hiding this comment.
Might also consider getting rid of the dominated check.
In the MOEA Framework, which is the precursor to this library, I actual split out two types of improvement:
/**
* The number of ε-box improvements that have occurred.
*/
private int numberOfImprovements;
/**
* The number of ε-box improvements dominating an existing solution
* that have occurred.
*/
private int numberOfDominatingImprovements;There was a problem hiding this comment.
Yeah, I think to keep the two libraries consistent, non-dominated solutions should count as improvements so long as they fall within a new epsilon-box.
gfag31
approved these changes
Jan 24, 2024
gfag31
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221