Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/megaphone #36

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Feature/megaphone #36

merged 3 commits into from
Sep 18, 2024

Conversation

Unique0902
Copy link
Contributor

megaphone 페이지, 기능 추가

메가폰 페이지로 이동하기 전 페이지인 웨이팅 페이지가 존재하지않아
따로 메가폰 페이지로 이동하는 인터렉션은 추가하지않음.

'megaphone/[boothid]' url로 이동하여 확인 가능.

Copy link

Deploy preview for unifest-web-deployment ready!

✅ Preview
https://unifest-web-deployment-at43honqg-algoorgoals-projects.vercel.app

Built with commit a02716b.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@algoORgoal algoORgoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

megaphon 수정하고서 pull request 승인할게요

export function Megaphone({ boothId }: { boothId: number }) {
const accessToken = useAuthStore((state) => state.accessToken);
const [booth, setBooth] = useState<Booth>();
const getAuthBooth = useAuthFetch(() => getBoothDetail(boothId));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디테일 보여주는 getBoothDetail이 그 때 api 상에 문제가 있어서 사용을 못했던 것으로 기억합니다 ㅠ
제가 알아서 수정해볼게요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBoothDetail 문제 수정된 것으로 확인

useEffect(() => {
const getBoothListEffect = async () => {
const data = await getAuthBooth();
if (data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response.data 자체가

{
  code: string;
  message: string;
  data: json
}

형태로 날라오기에

const { data } = await getAuthBoth(); 로 바꿔야 합니다


boothId: number,
msg: { msgBody: string },
) => {
const response = await fetch(`${API_URL}/booths/${boothId}/announcement`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 버전에서는 ${API_URL}/megaphone로 해야만 동작

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unifest-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 6:03am

@algoORgoal algoORgoal merged commit 1d497e3 into master Sep 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants