You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coming out of #576 and #812 (and as observed in #639) puppeteer as a heavy dependency. It's not new news by any means, but even for a simple getting started case like npx @greenwood/cli, for just a simple markdown file you still have to download puppeteer and a whole copy of chrome. As "Mr. Wonderful" would say; "stop the madness!"
Also, it uses npm postinstall hooks which is usually limited / blocked in cloud environments like Stackblitz.
Before making this not the default, perhaps we need to be able to accommodate #548 at the same time? Or at least know it's possible, otherwise there is no framework-less option to SSR web components, which is something I want as an option for Greenwood.
Another thought here is that we would likely want to update our Getting Started guide and docs since we are demonstrating using JavaScript for what should essentially be static content, which seems counter-intuitive without mentioning
prerendering
optimization config setting
Perhaps we should introduce an "advanced" step to call this out and how Greenwood can let you write JS for HTML with no runtime cost when combining prerendering with static optimization.
thescientist13
changed the title
make prerender config option false by default (should optionally install puppeteer only if needed)
make prerender config option false by default
Mar 18, 2022
Type of Change
Summary
Coming out of #576 and #812 (and as observed in #639) puppeteer as a heavy dependency. It's not new news by any means, but even for a simple getting started case like
npx @greenwood/cli
, for just a simple markdown file you still have to download puppeteer and a whole copy of chrome. As "Mr. Wonderful" would say; "stop the madness!"Also, it uses npm
postinstall
hooks which is usually limited / blocked in cloud environments like Stackblitz.Details
So by default, Greenwood should
prerender
to falseoptionalDependecny
?)prerender: true
and tries to run the build, check for puppeteer and if needed, install on the flyThe text was updated successfully, but these errors were encountered: