Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/upgrade official rollup terser plugin #1012

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 30, 2022

Related Issue

Noticed an install error that highlighted rollup-plugin-terser as being deprecated.
Screen Shot 2022-11-29 at 9 18 48 PM

Summary of Changes

  1. Migrate to official @rollup organization plugin
  2. Updated a couple specs for minor variances as part of migrating
  3. Removed a duplicate call to terser() which seemed to be causing some double runs, hence the TypeScript and JSON specs being changed. I confirmed in the REPL though that the output in the specs is the output to expect from Rollup.
    Screen Shot 2022-11-29 at 8 57 21 PM

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI v0.28.0 labels Nov 30, 2022
@thescientist13 thescientist13 force-pushed the enhancement/upgrade-official-rollup-terser-plugin branch from 327108b to dbec42c Compare December 10, 2022 14:21
@thescientist13 thescientist13 added dependencies Pull requests that update a dependency file and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Dec 10, 2022
@thescientist13 thescientist13 merged commit b83b437 into master Dec 10, 2022
@thescientist13 thescientist13 deleted the enhancement/upgrade-official-rollup-terser-plugin branch December 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI dependencies Pull requests that update a dependency file v0.27.2
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant